Remove relayouting linear weights logic from hf-adapters load-common.py - #280
Merged
arielge merged 3 commits intoAug 13, 2026
Merged
Conversation
Contributor
Author
|
Tested with and without patch and no significant regression found after removing relayout function from hf-adapters |
1 task
vinithakv
force-pushed
the
remove-relayout-redundant-logic
branch
from
August 5, 2026 15:46
920bbfa to
5eb92b6
Compare
vinithakv
marked this pull request as ready for review
August 5, 2026 15:47
arielge
reviewed
Aug 5, 2026
arielge
requested changes
Aug 13, 2026
| @@ -1180,47 +1145,7 @@ def _move_to_spyre_with_layout(model, dtype): | |||
Contributor
There was a problem hiding this comment.
This is now redundant as well
Contributor
There was a problem hiding this comment.
(since we have one model.to that is valid for both spyre and cpu)
arielge
approved these changes
Aug 13, 2026
The relayouting is handled in torch_spyre/model_utils.py Signed-off-by: Vinitha Vijayan <vinithav@linux.vnet.ibm.com>
Signed-off-by: Vinitha Vijayan <vinithav@linux.vnet.ibm.com>
Signed-off-by: Vinitha Vijayan <vinithav@linux.vnet.ibm.com>
arielge
force-pushed
the
remove-relayout-redundant-logic
branch
from
August 13, 2026 12:11
e8d72fb to
0422927
Compare
arielge
enabled auto-merge
August 13, 2026 12:12
❌ merge-queue-integration: failure |
⏳ merge-queue-integration: queued |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relayouting is handled in torch_spyre/model_utils.py